fix(mapgen-studio): replace empty grid toggle placeholder with Grid3x3 lucide icon#1637
Merged
Conversation
This was referenced Jun 12, 2026
Merged
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
Merged
|
Railway preview (MapGen Studio): not provisioned for this PR. Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.
Debug: |
This was referenced Jun 12, 2026
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/toolbar-architecture-v2
branch
from
June 12, 2026 20:44
27252f0 to
66bd12d
Compare
mateicanavra
force-pushed
the
design/grid-icon
branch
from
June 12, 2026 20:44
f4fb8f9 to
27213b1
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/toolbar-architecture-v2
to
graphite-base/1637
June 12, 2026 21:54
mateicanavra
force-pushed
the
design/grid-icon
branch
from
June 12, 2026 21:56
27213b1 to
1aa584e
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grid visibility toggle in
ViewControlswas rendering an empty<div className="w-4 h-4" />in place of its icon, making the button body invisible to users. This replaces that placeholder with theGrid3x3lucide icon, consistent with the established rule that all icon-only controls must render a visible glyph from lucide-react with no empty placeholders or alternative icon systems.A categorical sweep of the source and live DOM confirmed no other empty icon-sized placeholders exist — the only legitimately glyph-less visible button is the overrides
Switch, whose thumb serves as its body by design.